From a3126635d4c5c2e81d426778e9ecb5dbf0425943 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 1 May 2014 15:29:18 +0200 Subject: [PATCH] Revert changes in _click --- qutebrowser/browser/hints.py | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 716d9d565..4ee0ab103 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -207,24 +207,19 @@ class HintManager(QObject): css, string)) return doc.lastChild() - def _click(self, elem, target=None, frame=None): + def _click(self, elem): """Click an element. Args: elem: The QWebElement to click. - target_override: Target which overrides self._target """ - if target is not None: - pass - elif self._target == 'rapid': + if self._target == 'rapid': target = 'bgtab' else: target = self._target - if frame is None: - frame = self._frame self.set_open_target.emit(target) point = elem.geometry().topLeft() - scrollpos = frame.scrollPosition() + scrollpos = self._frame.scrollPosition() logging.debug("Clicking on \"{}\" at {}/{} - {}/{}".format( elem.toPlainText(), point.x(), point.y(), scrollpos.x(), scrollpos.y()))