rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove 'group by' from url completion query.

Browse Source 
This seemed to have a significant performance impact. Removing it means
that instead of just seeing the most recent atime for a given url, you
will see multiple entries.
This commit is contained in:
Ryan Roden-Corrent 2017-06-02 07:47:28 -04:00
parent c297f047d2
commit a01c76db54
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/completion/models/urlmodel.py
View File

@ -75,9 +75,9 @@ def url():
columns_to_filter=[0, 1])) columns_to_filter=[0, 1]))
timefmt = config.get('completion', 'timestamp-format') timefmt = config.get('completion', 'timestamp-format')
select_time = "strftime('{}', max(atime), 'unixepoch')".format(timefmt) select_time = "strftime('{}', atime, 'unixepoch')".format(timefmt)
hist_cat = sqlcategory.SqlCategory( hist_cat = sqlcategory.SqlCategory(
'History', sort_order='desc', sort_by='atime', group_by='url', 'History', sort_order='desc', sort_by='atime',
filter_fields=['url', 'title'], filter_fields=['url', 'title'],
select='url, title, {}'.format(select_time), where='not redirect') select='url, title, {}'.format(select_time), where='not redirect')
model.add_category(hist_cat) model.add_category(hist_cat)

2
tests/unit/completion/test_models.py
View File

@ -306,7 +306,9 @@ def test_url_completion(qtmodeltester, config_stub, web_history, quickmarks,
"History": [ "History": [
('https://github.com', 'https://github.com', '2016-05-01'), ('https://github.com', 'https://github.com', '2016-05-01'),
('https://python.org', 'Welcome to Python.org', '2016-03-08'), ('https://python.org', 'Welcome to Python.org', '2016-03-08'),
('https://python.org', 'Welcome to Python.org', '2016-02-08'),
('http://qutebrowser.org', 'qutebrowser', '2015-09-05'), ('http://qutebrowser.org', 'qutebrowser', '2015-09-05'),
('https://python.org', 'Welcome to Python.org', '2014-03-08'),
], ],
}) })