diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index 01f626ead..66c6768d5 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -32,6 +32,8 @@ Fixed ~~~~~ - Fixed completion for various config values when using `:set`. +- Prevented an error being logged when a website with HTTP authentication was + opened on Windows. v0.5.0 ------ diff --git a/qutebrowser/browser/network/networkmanager.py b/qutebrowser/browser/network/networkmanager.py index 4670cb186..a222f2713 100644 --- a/qutebrowser/browser/network/networkmanager.py +++ b/qutebrowser/browser/network/networkmanager.py @@ -19,6 +19,7 @@ """Our own QNetworkAccessManager.""" +import os import collections import netrc @@ -256,7 +257,10 @@ class NetworkManager(QNetworkAccessManager): def on_authentication_required(self, reply, authenticator): """Called when a website needs authentication.""" user, password = None, None - if not hasattr(reply, "netrc_used"): + if not hasattr(reply, "netrc_used") and 'HOME' in os.environ: + # We'll get an OSError by netrc if 'HOME' isn't available in + # os.environ. We don't want to log that, so we prevent it + # altogether. reply.netrc_used = True try: net = netrc.netrc()