rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

downloads: Fix size calculation with unknown size.

Browse Source 
Fixes #854.
This commit is contained in:
Florian Bruhin 2015-08-06 20:57:40 +02:00
parent 36adaf0cf3
commit 9c6782be1d
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -59,6 +59,7 @@ Fixed
- Fixed potential crash when hinting a text field. - Fixed potential crash when hinting a text field.
- Fixed entering of insert mode when certain disabled text fields were clicked. - Fixed entering of insert mode when certain disabled text fields were clicked.
- Fixed a crash when using `:set` with `-p` and `!` (invert value) - Fixed a crash when using `:set` with `-p` and `!` (invert value)
- Downloads with unknown size are now handled correctly.
Removed Removed
~~~~~~~ ~~~~~~~

8
qutebrowser/browser/downloads.py
View File

@ -121,6 +121,10 @@ class DownloadItemStats(QObject):
The caller needs to guarantee this is called all REFRESH_INTERVAL ms. The caller needs to guarantee this is called all REFRESH_INTERVAL ms.
""" """
if self.done is None:
# this can happen for very fast downloads, e.g. when actually
# opening a file
return
delta = self.done - self._last_done delta = self.done - self._last_done
self.speed = delta * 1000 / REFRESH_INTERVAL self.speed = delta * 1000 / REFRESH_INTERVAL
self._speed_avg.append(self.speed) self._speed_avg.append(self.speed)
@ -132,7 +136,9 @@ class DownloadItemStats(QObject):
def percentage(self): def percentage(self):
"""The current download percentage, or None if unknown.""" """The current download percentage, or None if unknown."""
if self.total == 0 or self.total is None: if self.done == self.total:
return 100
elif self.total == 0 or self.total is None:
return None return None
else: else:
return 100 * self.done / self.total return 100 * self.done / self.total