rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Re-enable segfault reports for QtWebEngine

Browse Source 
Fixes #2174
This commit is contained in:
Florian Bruhin 2017-02-05 18:49:06 +01:00
parent 2193551035
commit 9b843f24eb
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.asciidoc
View File

@ -47,6 +47,7 @@ Fixed
- Word hints are now upper-cased correctly when hints -> uppercase is true - Word hints are now upper-cased correctly when hints -> uppercase is true
- Font validation is now more permissive in the config, allowing e.g. "Terminus - Font validation is now more permissive in the config, allowing e.g. "Terminus
(TTF)" as font name. (TTF)" as font name.
- Crash reports are now re-enabled when using QtWebEngine
v0.9.1 v0.9.1
------ ------

8
qutebrowser/misc/crashdialog.py
View File

@ -35,9 +35,9 @@ from PyQt5.QtWidgets import (QDialog, QLabel, QTextEdit, QPushButton,
QDialogButtonBox, QMessageBox, QApplication) QDialogButtonBox, QMessageBox, QApplication)
import qutebrowser import qutebrowser
from qutebrowser.utils import version, log, utils, objreg from qutebrowser.utils import version, log, utils, objreg, usertypes
from qutebrowser.misc import (miscwidgets, autoupdate, msgbox, httpclient, from qutebrowser.misc import (miscwidgets, autoupdate, msgbox, httpclient,
pastebin) pastebin, objects)
from qutebrowser.config import config from qutebrowser.config import config
@ -82,7 +82,9 @@ def get_fatal_crash_dialog(debug, data):
ignored_frames = ['qt_mainloop', 'paintEvent'] ignored_frames = ['qt_mainloop', 'paintEvent']
errtype, frame = parse_fatal_stacktrace(data) errtype, frame = parse_fatal_stacktrace(data)
if errtype == 'Segmentation fault' and frame in ignored_frames: if (errtype == 'Segmentation fault' and
frame in ignored_frames and
objects.backend == usertypes.Backend.QtWebKit):
title = "qutebrowser was restarted after a fatal crash!" title = "qutebrowser was restarted after a fatal crash!"
text = ("<b>qutebrowser was restarted after a fatal crash!</b><br/>" text = ("<b>qutebrowser was restarted after a fatal crash!</b><br/>"
"Unfortunately, this crash occurred in Qt (the library " "Unfortunately, this crash occurred in Qt (the library "