rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

style: Check for QColor when setting in ColorDict.

Browse Source
This commit is contained in:
Florian Bruhin 2015-08-19 20:39:16 +02:00
parent dc0e8b4626
commit 9b82fae6fb
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
qutebrowser/config/style.py
View File

@ -72,6 +72,17 @@ class ColorDict(dict):
"""A dict aimed at Qt stylesheet colors."""
def __setitem__(self, key, val):
"""Override __setitem__ to make sure no QColors are set.
This could happen when accidentally declaring something as QtColor
instead of Color in the config, and it'd go unnoticed as the CSS is
invalid then.
"""
if isinstance(val, QColor):
raise TypeError("QColor passed to ColorDict!")
super().__setitem__(key, val)
def __getitem__(self, key):
"""Override dict __getitem__.
@ -92,11 +103,6 @@ class ColorDict(dict):
except KeyError:
log.config.exception("No color defined for {}!")
return ''
if isinstance(val, QColor):
# This could happen when accidentally declaring something as
# QtColor instead of Color in the config, and it'd go unnoticed as
# the CSS is invalid then.
raise TypeError("QColor passed to ColorDict!")
if 'fg' in key.split('.'):
return 'color: {};'.format(val)
elif 'bg' in key.split('.'):