rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

extended tests to cover new file argument

Browse Source
This commit is contained in:
Felix Van der Jeugt 2016-01-17 20:38:33 +01:00
parent 362db3d986
commit 9a889c6866
1 changed files with 20 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
tests/unit/config/test_configtypes.py
View File

@ -1256,12 +1256,21 @@ class TestRegexList:
assert klass().transform(val) == expected assert klass().transform(val) == expected
def unrequired_class(**kwargs):
return configtypes.File(required=False, **kwargs)
@pytest.mark.usefixtures('qapp') @pytest.mark.usefixtures('qapp')
class TestFileAndUserStyleSheet: class TestFileAndUserStyleSheet:
"""Test File/UserStyleSheet.""" """Test File/UserStyleSheet."""
@pytest.fixture(params=[configtypes.File, configtypes.UserStyleSheet]) @pytest.fixture(params=[
configtypes.File,
configtypes.UserStyleSheet,
unrequired_class,
])
def klass(self, request): def klass(self, request):
return request.param return request.param
@ -1281,6 +1290,8 @@ class TestFileAndUserStyleSheet:
return arg return arg
elif klass is configtypes.UserStyleSheet: elif klass is configtypes.UserStyleSheet:
return QUrl.fromLocalFile(arg) return QUrl.fromLocalFile(arg)
elif klass is unrequired_class:
return arg
else: else:
assert False, klass assert False, klass
@ -1297,6 +1308,11 @@ class TestFileAndUserStyleSheet:
with pytest.raises(configexc.ValidationError): with pytest.raises(configexc.ValidationError):
configtypes.File().validate('foobar') configtypes.File().validate('foobar')
def test_validate_does_not_exist_optional_file(self, os_mock):
"""Test validate with a file which does not exist (File)."""
os_mock.path.isfile.return_value = False
configtypes.File(required=False).validate('foobar')
def test_validate_does_not_exist_userstylesheet(self, os_mock): def test_validate_does_not_exist_userstylesheet(self, os_mock):
"""Test validate with a file which does not exist (UserStyleSheet).""" """Test validate with a file which does not exist (UserStyleSheet)."""
os_mock.path.isfile.return_value = False os_mock.path.isfile.return_value = False
@ -1331,7 +1347,9 @@ class TestFileAndUserStyleSheet:
(configtypes.File(), 'foobar', True), (configtypes.File(), 'foobar', True),
(configtypes.UserStyleSheet(), 'foobar', False), (configtypes.UserStyleSheet(), 'foobar', False),
(configtypes.UserStyleSheet(), '\ud800', True), (configtypes.UserStyleSheet(), '\ud800', True),
], ids=['file-foobar', 'userstylesheet-foobar', 'userstylesheet-unicode']) (configtypes.File(required=False), 'foobar', False),
], ids=['file-foobar', 'userstylesheet-foobar', 'userstylesheet-unicode',
'file-optional-foobar'])
def test_validate_rel_inexistent(self, os_mock, monkeypatch, configtype, def test_validate_rel_inexistent(self, os_mock, monkeypatch, configtype,
value, raises): value, raises):
"""Test with a relative path and standarddir.config returning None.""" """Test with a relative path and standarddir.config returning None."""