rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix is_special_url (use QUrl).

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-20 20:21:52 +02:00
parent 7de637baea
commit 9a33efdb3f
2 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qutebrowser/test/utils/test_url.py
View File

@ -24,6 +24,8 @@
import unittest import unittest
from unittest import TestCase from unittest import TestCase
from PyQt5.QtCore import QUrl
import qutebrowser.utils.url as urlutils import qutebrowser.utils.url as urlutils
@ -85,12 +87,14 @@ class SpecialURLTests(TestCase):
def test_special_urls(self): def test_special_urls(self):
"""Test special URLs.""" """Test special URLs."""
for url in self.SPECIAL_URLS: for url in self.SPECIAL_URLS:
self.assertTrue(urlutils.is_special_url(url)) u = QUrl(url)
self.assertTrue(urlutils.is_special_url(u))
def test_normal_urls(self): def test_normal_urls(self):
"""Test non-special URLs.""" """Test non-special URLs."""
for url in self.NORMAL_URLS: for url in self.NORMAL_URLS:
self.assertFalse(urlutils.is_special_url(url)) u = QUrl(url)
self.assertFalse(urlutils.is_special_url(u))
class SearchUrlTests(TestCase): class SearchUrlTests(TestCase):

8
qutebrowser/utils/url.py
View File

@ -131,9 +131,13 @@ def fuzzy_url(urlstr):
def is_special_url(url): def is_special_url(url):
"""Return True if url is an about:... or other special URL.""" """Return True if url is an about:... or other special URL.
Args:
url: The URL as QUrl.
"""
special_schemes = ('about', 'qute', 'file') special_schemes = ('about', 'qute', 'file')
return QUrl(url).scheme() in special_schemes return url.scheme() in special_schemes
def is_url(urlstr): def is_url(urlstr):