From 5e9fa2b57ee3ad6135710a5bd0075638b06d4083 Mon Sep 17 00:00:00 2001 From: Jan Verbeek Date: Wed, 29 Jun 2016 00:12:44 +0200 Subject: [PATCH 1/2] Make gg accept count --- qutebrowser/browser/commands.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/browser/commands.py b/qutebrowser/browser/commands.py index eb2f31575..1fed76c70 100644 --- a/qutebrowser/browser/commands.py +++ b/qutebrowser/browser/commands.py @@ -600,7 +600,7 @@ class CommandDispatcher: if perc is None and count is None: perc = 100 - elif perc is None: + elif count is not None: perc = count orientation = Qt.Horizontal if horizontal else Qt.Vertical From 3c2c7ecaaefaacac4dde9954afed962479463b1d Mon Sep 17 00:00:00 2001 From: Jan Verbeek Date: Wed, 29 Jun 2016 11:47:51 +0200 Subject: [PATCH 2/2] Test for scroll with count and argument --- tests/end2end/features/scroll.feature | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/tests/end2end/features/scroll.feature b/tests/end2end/features/scroll.feature index 676cd0890..50c22971a 100644 --- a/tests/end2end/features/scroll.feature +++ b/tests/end2end/features/scroll.feature @@ -190,6 +190,10 @@ Feature: Scrolling And I run :scroll-perc 20 Then no crash should happen + Scenario: :scroll-perc with count and argument + When I run :scroll-perc 0 with count 50 + Then the page should be scrolled vertically + ## :scroll-page Scenario: Scrolling down with :scroll-page