From 1941af8add77198fcd1746a2394f7bb67d455b60 Mon Sep 17 00:00:00 2001 From: Corentin Jule Date: Thu, 3 Dec 2015 20:48:50 +0100 Subject: [PATCH 1/3] Fix TypeError on ConfigManager.remove_option --- qutebrowser/config/config.py | 2 +- qutebrowser/config/sections.py | 4 ++++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/qutebrowser/config/config.py b/qutebrowser/config/config.py index 42f9395e2..57837084f 100644 --- a/qutebrowser/config/config.py +++ b/qutebrowser/config/config.py @@ -619,7 +619,7 @@ class ConfigManager(QObject): optname = self.optionxform(optname) existed = optname in sectdict if existed: - del sectdict[optname] + sectdict.delete(optname) # WORKAROUND for https://bitbucket.org/logilab/pylint/issues/659/ self.get.cache_clear() # pylint: disable=no-member return existed diff --git a/qutebrowser/config/sections.py b/qutebrowser/config/sections.py index 2a20b5b80..0253777cc 100644 --- a/qutebrowser/config/sections.py +++ b/qutebrowser/config/sections.py @@ -72,6 +72,10 @@ class Section: """Get value keys.""" return self.values.keys() + def delete(self, key): + """Delete item with given key""" + del self.values[key] + def setv(self, layer, key, value, interpolated): """Set the value on a layer. From d8d873f04452c9f4789082fabdc5073e0eebcee4 Mon Sep 17 00:00:00 2001 From: Corentin Jule Date: Fri, 4 Dec 2015 00:28:58 +0100 Subject: [PATCH 2/3] Fix typo for Pep257 --- qutebrowser/config/sections.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/config/sections.py b/qutebrowser/config/sections.py index 0253777cc..bedde27aa 100644 --- a/qutebrowser/config/sections.py +++ b/qutebrowser/config/sections.py @@ -73,7 +73,7 @@ class Section: return self.values.keys() def delete(self, key): - """Delete item with given key""" + """Delete item with given key.""" del self.values[key] def setv(self, layer, key, value, interpolated): From 491a02e4a5f8cf7862280dd38623e3074e505e91 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 4 Dec 2015 18:33:05 +0100 Subject: [PATCH 3/3] Regenerate authors. --- README.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/README.asciidoc b/README.asciidoc index b8aa08aad..436f03409 100644 --- a/README.asciidoc +++ b/README.asciidoc @@ -183,6 +183,7 @@ Contributors, sorted by the number of commits in descending order: * Mathias Fussenegger * Fritz V155 Reichwald * Franz Fellner +* Corentin Jule * zwarag * xd1le * Tim Harder