From 97e00ba4b529e0791d6a306478f693ae3b12775b Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 25 Feb 2018 15:03:30 +0100 Subject: [PATCH] Only reload after setting changes when needed Apparently, things work fine with Type.link_clicked even if we don't emit predicted_navigation there... --- qutebrowser/browser/webengine/webenginetab.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 4fcb6d279..be7929510 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -914,7 +914,9 @@ class WebEngineTab(browsertab.AbstractTab): super()._on_navigation_request(navigation) if navigation.accepted and navigation.is_main_frame: changed = self.settings.update_for_url(navigation.url) - if changed & {'content.plugins', 'content.javascript.enabled'}: + if (changed & {'content.plugins', 'content.javascript.enabled'} and + navigation.navigation_type != navigation.Type.link_clicked): + # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-66656 self._reload_url = navigation.url def _connect_signals(self):