rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add a stop-gap solution for AssertionError when retrying downloads

Browse Source 
See #3847
This commit is contained in:
Florian Bruhin 2018-05-03 14:52:10 +02:00
parent 2b6b4e82a7
commit 979b7cfaba
2 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
doc/changelog.asciidoc
View File

@ -90,6 +90,7 @@ Fixed
- `@match` in Greasemonkey scripts now more closely matches the proper pattern - `@match` in Greasemonkey scripts now more closely matches the proper pattern
syntax. syntax.
- Searching via `/` or `?` now doesn't handle any characters in a special way. - Searching via `/` or `?` now doesn't handle any characters in a special way.
- Fixed crash when trying to retry some failed downloads on QtWebEngine.
v1.2.1 v1.2.1
------ ------

6
qutebrowser/browser/webengine/webenginedownloads.py
View File

@ -101,7 +101,11 @@ class DownloadItem(downloads.AbstractDownloadItem):
def retry(self): def retry(self):
state = self._qt_item.state() state = self._qt_item.state()
assert state == QWebEngineDownloadItem.DownloadInterrupted, state if state != QWebEngineDownloadItem.DownloadInterrupted:
log.downloads.warning(
"Trying to retry download in state {}".format(
debug.qenum_key(QWebEngineDownloadItem, state)))
return
try: try:
self._qt_item.resume() self._qt_item.resume()