Remove some old FIXMEs

qutebrowser/commands/command.py

@@ -48,7 +48,7 @@ class Command(QObject):
                 from the app.py context.
     """
 
-    # FIXME:
+    # TODO:
     # we should probably have some kind of typing / argument casting for args
     # this might be combined with help texts or so as well
 

qutebrowser/commands/utils.py

@@ -79,7 +79,6 @@ class register:  # pylint: disable=invalid-name
         Return:
             The original function (unmodified).
         """
-        # FIXME: only register commands once
         names = []
         name = func.__name__.lower() if self.name is None else self.name
         if isinstance(name, str):

qutebrowser/config/config.py

@@ -362,7 +362,6 @@ class Config(QObject):
         Return:
             The changed config part as string.
         """
-        # FIXME adopt this for layering
         lines = []
         for secname, section in self.sections.items():
             changed = section.dump_userconfig()

qutebrowser/config/conftypes.py

@@ -436,7 +436,7 @@ class Font(BaseType):
     typestr = 'font'
 
     def validate(self, value):
-        # FIXME validate fonts
+        # We can't really validate anything here
         pass
 
 

qutebrowser/config/style.py

@@ -82,10 +82,6 @@ class ColorDict(dict):
 
     """A dict aimed at Qt stylesheet colors."""
 
-    # FIXME we should validate colors in __setitem__ based on:
-    # http://qt-project.org/doc/qt-4.8/stylesheet-reference.html#brush
-    # http://www.w3.org/TR/CSS21/syndata.html#color-units
-
     def __getitem__(self, key):
         """Override dict __getitem__.
 

qutebrowser/models/completion.py

@@ -262,8 +262,6 @@ class CompletionModel(QAbstractItemModel):
         Return:
             The item flags, or Qt.NoItemFlags on error.
         """
-        # FIXME categories are not selectable, but moving via arrow keys still
-        # tries to select them
         if not index.isValid():
             return Qt.NoItemFlags
         flags = Qt.ItemIsEnabled

qutebrowser/network/qutescheme.py

@@ -89,7 +89,6 @@ class QuteSchemeHandler(SchemeHandler):
         """
         # pylint: disable=unused-argument
         # FIXME handle unknown pages
-        # FIXME adjust URLutils based on handlers
         logging.debug('request: {}'.format(request))
         url = urlstring(request.url())
         handler = getattr(QuteHandlers, self._transform_url(url))

qutebrowser/utils/keyparser.py

@@ -110,7 +110,7 @@ class KeyParser(QObject):
         Args:
             e: the KeyPressEvent from Qt.
         """
-        # FIXME maybe we can do this in an easier way by using QKeySeqyence
+        # FIXME maybe we can do this in an easier way by using QKeySequence
         # which has a matches method.
         logging.debug('Got key: {} / text: "{}"'.format(e.key(), e.text()))
         txt = e.text().strip()

qutebrowser/utils/url.py

@@ -84,8 +84,8 @@ def _is_url_dns(url):
     Return:
         True if the url really is an URL, False otherwise.
     """
-    # FIXME we could probably solve this in a nicer way by attempting to open
+    # FIXME If we use Qt's methods to resolve URLs, we could benefit from the
-    # the page in the webview, and then open the search if that fails.
+    # build-in cache and wouldn't have to resolve again.
     host = url.host()
     logging.debug("DNS request for {}".format(host))
     if not host:

qutebrowser/widgets/completion.py

@@ -133,7 +133,7 @@ class CompletionView(QTreeView):
         self.setHeaderHidden(True)
         self.setIndentation(0)
         self.setItemsExpandable(False)
-        # FIXME This is a workaround for weird race conditions with invalid
+        # QTBUG? This is a workaround for weird race conditions with invalid
         # item indexes leading to segfaults in Qt.
         #
         # Some background: http://bugs.quassel-irc.org/issues/663
@@ -379,8 +379,8 @@ class _CompletionItemDelegate(QStyledItemDelegate):
         if state & QStyle.State_Selected:
             self._painter.setPen(self._opt.palette.color(
                 cg, QPalette.HighlightedText))
-            # FIXME this is a dirty fix for the text jumping by one pixel...
+            # This is a dirty fix for the text jumping by one pixel for
-            # we really should do this properly somehow
+            # whatever reason.
             text_rect.adjust(0, -1, 0, 0)
         else:
             self._painter.setPen(self._opt.palette.color(cg, QPalette.Text))

qutebrowser/widgets/statusbar.py

@@ -455,8 +455,6 @@ class TextBase(QLabel):
         when the text is empty -- we explicitely need to call repaint() to
         resolve this. See http://stackoverflow.com/q/21890462/2085149
 
-        FIXME is there a nicer way to work around this?
-
         Args:
             txt: The text to set (string).
         """

qutebrowser/widgets/tabbedbrowser.py

@@ -206,7 +206,6 @@ class TabbedBrowser(TabWidget):
             return
         last_close = config.get('tabbar', 'last_close')
         if self.count() > 1:
-            # FIXME maybe we actually should store the webview objects here
             self._url_stack.append(tab.url())
             self.removeTab(idx)
             tab.shutdown(callback=partial(self._cb_tab_shutdown, tab))
@@ -231,7 +230,6 @@ class TabbedBrowser(TabWidget):
         self._connect_tab_signals(tab)
         self._tabs.append(tab)
         self.addTab(tab, urlutils.urlstring(url))
-        # FIXME sometimes this doesn't load
         tab.show()
         tab.openurl(url)
         if not background: