rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix validation of ShellCommand config type.

Browse Source 
Fixes #432.
This commit is contained in:
Florian Bruhin 2015-01-03 21:19:43 +01:00
parent e54d3c21ee
commit 9521d253a1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/config/configtypes.py
View File

@ -937,13 +937,13 @@ class ShellCommand(BaseType):
return return
else: else:
raise configexc.ValidationError(value, "may not be empty!") raise configexc.ValidationError(value, "may not be empty!")
if self.placeholder and '{}' not in self.transform(value):
raise configexc.ValidationError(value, "needs to contain a "
"{}-placeholder.")
try: try:
shlex.split(value) shlex.split(value)
except ValueError as e: except ValueError as e:
raise configexc.ValidationError(value, str(e)) raise configexc.ValidationError(value, str(e))
if self.placeholder and '{}' not in self.transform(value):
raise configexc.ValidationError(value, "needs to contain a "
"{}-placeholder.")
def transform(self, value): def transform(self, value):
if not value: if not value: