Actually connect _on_url_changed slot
This commit is contained in:
parent
f46d6cbe27
commit
914f9db8ca
@ -502,6 +502,7 @@ class AbstractTab(QWidget):
|
||||
"""Update title when URL has changed and no title is available."""
|
||||
if url.isValid() and not self.title():
|
||||
self.title_changed.emit(url().toDisplayString())
|
||||
self.url_changed.emit()
|
||||
|
||||
@pyqtSlot()
|
||||
def _on_load_started(self):
|
||||
|
@ -317,7 +317,7 @@ class WebEngineTab(browsertab.AbstractTab):
|
||||
page.loadProgress.connect(self._on_load_progress)
|
||||
page.loadStarted.connect(self._on_load_started)
|
||||
view.titleChanged.connect(self.title_changed)
|
||||
view.urlChanged.connect(self.url_changed)
|
||||
view.urlChanged.connect(self._on_url_changed)
|
||||
page.loadFinished.connect(self._on_load_finished)
|
||||
page.certificate_error.connect(self._on_ssl_errors)
|
||||
# FIXME:qtwebengine stub this?
|
||||
|
@ -521,7 +521,7 @@ class WebKitTab(browsertab.AbstractTab):
|
||||
frame.loadStarted.connect(self._on_load_started)
|
||||
view.scroll_pos_changed.connect(self.scroll.perc_changed)
|
||||
view.titleChanged.connect(self.title_changed)
|
||||
view.urlChanged.connect(self.url_changed)
|
||||
view.urlChanged.connect(self._on_url_changed)
|
||||
view.shutting_down.connect(self.shutting_down)
|
||||
page.networkAccessManager().sslErrors.connect(self._on_ssl_errors)
|
||||
|
||||
|
Loading…
Reference in New Issue
Block a user