rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Actually connect _on_url_changed slot

Browse Source
This commit is contained in:
Florian Bruhin 2016-07-11 16:05:09 +02:00
parent f46d6cbe27
commit 914f9db8ca
3 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
qutebrowser/browser/browsertab.py
View File

@ -502,6 +502,7 @@ class AbstractTab(QWidget):
"""Update title when URL has changed and no title is available.""" """Update title when URL has changed and no title is available."""
if url.isValid() and not self.title(): if url.isValid() and not self.title():
self.title_changed.emit(url().toDisplayString()) self.title_changed.emit(url().toDisplayString())
self.url_changed.emit()
@pyqtSlot() @pyqtSlot()
def _on_load_started(self): def _on_load_started(self):

2
qutebrowser/browser/webengine/webenginetab.py
View File

@ -317,7 +317,7 @@ class WebEngineTab(browsertab.AbstractTab):
page.loadProgress.connect(self._on_load_progress) page.loadProgress.connect(self._on_load_progress)
page.loadStarted.connect(self._on_load_started) page.loadStarted.connect(self._on_load_started)
view.titleChanged.connect(self.title_changed) view.titleChanged.connect(self.title_changed)
view.urlChanged.connect(self.url_changed) view.urlChanged.connect(self._on_url_changed)
page.loadFinished.connect(self._on_load_finished) page.loadFinished.connect(self._on_load_finished)
page.certificate_error.connect(self._on_ssl_errors) page.certificate_error.connect(self._on_ssl_errors)
# FIXME:qtwebengine stub this? # FIXME:qtwebengine stub this?

2
qutebrowser/browser/webkit/webkittab.py
View File

@ -521,7 +521,7 @@ class WebKitTab(browsertab.AbstractTab):
frame.loadStarted.connect(self._on_load_started) frame.loadStarted.connect(self._on_load_started)
view.scroll_pos_changed.connect(self.scroll.perc_changed) view.scroll_pos_changed.connect(self.scroll.perc_changed)
view.titleChanged.connect(self.title_changed) view.titleChanged.connect(self.title_changed)
view.urlChanged.connect(self.url_changed) view.urlChanged.connect(self._on_url_changed)
view.shutting_down.connect(self.shutting_down) view.shutting_down.connect(self.shutting_down)
page.networkAccessManager().sslErrors.connect(self._on_ssl_errors) page.networkAccessManager().sslErrors.connect(self._on_ssl_errors)