Merge pull request #3445 from seelaman/hist_import-cleaning

filter out records with None in any field.
This commit is contained in:
Florian Bruhin 2018-01-15 19:15:08 +01:00 committed by GitHub
commit 8fd6a2ff77
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -100,16 +100,23 @@ def clean(history):
"""Clean up records from source database.
Receives a list of record and sanityze them in order for them to be
properly imported to qutebrowser. Sanitation requires addiing a 4th
properly imported to qutebrowser. Sanitation requires adding a 4th
attribute 'redirect' which is filled with '0's, and also purging all
records that have a NULL/None datetime attribute.
Args:
history: List of records (datetime, url, title) from source database.
"""
nulls = [record for record in history if record[0] is None]
for null_datetime in nulls:
history.remove(null_datetime)
# replace missing titles with an empty string
for index, record in enumerate(history):
if record[1] is None:
cleaned = list(record)
cleaned[1] = ''
history[index] = tuple(cleaned)
nulls = [record for record in history if None in record]
for null_record in nulls:
history.remove(null_record)
history = [list(record) for record in history]
for record in history:
record.append('0')