rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix signal cache

Browse Source
This commit is contained in:
Florian Bruhin 2014-02-05 17:19:52 +01:00
parent 0477df72b7
commit 8e35fb5656
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/widgets/browser.py
View File

@ -331,6 +331,12 @@ class TabbedBrowser(TabWidget):
signal -- The signal to emit if the sender was the current widget. signal -- The signal to emit if the sender was the current widget.
*args -- The args to pass to the signal. *args -- The args to pass to the signal.
""" """
# FIXME BUG the signal cache ordering seems to be weird sometimes.
# How to reproduce:
# - Open tab
# - While loading, open another tab
# - Switch back to #1 when loading finished
# - It seems loadingStarted is before loadingFinished
dbgstr = "{} ({})".format( dbgstr = "{} ({})".format(
signal.signal, ','.join([str(e) for e in args])) signal.signal, ','.join([str(e) for e in args]))
sender = self.sender() sender = self.sender()
@ -339,6 +345,10 @@ class TabbedBrowser(TabWidget):
logging.warn('Got signal "{}" by {} which is no tab!'.format( logging.warn('Got signal "{}" by {} which is no tab!'.format(
dbgstr, sender)) dbgstr, sender))
return return
if signal.signal in sender.signal_cache:
sender.signal_cache[signal.signal] = (signal, args)
sender.signal_cache.move_to_end(signal.signal)
else:
sender.signal_cache[signal.signal] = (signal, args) sender.signal_cache[signal.signal] = (signal, args)
if self.currentWidget() == sender: if self.currentWidget() == sender:
if not signal.signal.startswith('2cur_progress'): if not signal.signal.startswith('2cur_progress'):