From 8da942ddc759d9dcacd4a3a5f03492d72103e0cb Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 18 Aug 2016 22:46:32 +0200 Subject: [PATCH] bdd: Skip tests on WebEngine causing memory leaks --- qutebrowser/browser/webengine/webenginetab.py | 3 +++ tests/end2end/features/scroll.feature | 3 +++ 2 files changed, 6 insertions(+) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index acc3c19ee..99464468d 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -182,6 +182,9 @@ class WebEngineScroller(browsertab.AbstractScroller): """QtWebEngine implementations related to scrolling.""" + # FIXME:qtwebengine + # using stuff here with a big count/argument causes memory leaks and hangs + def __init__(self, tab, parent=None): super().__init__(tab, parent) self._pos_perc = (0, 0) diff --git a/tests/end2end/features/scroll.feature b/tests/end2end/features/scroll.feature index dec0ddce2..b14155ab1 100644 --- a/tests/end2end/features/scroll.feature +++ b/tests/end2end/features/scroll.feature @@ -121,6 +121,7 @@ Feature: Scrolling And I run :scroll left Then the page should not be scrolled + @qtwebengine_skip: Causes memory leak... Scenario: Scrolling down with a very big count When I run :scroll down with count 99999999999 # Make sure it doesn't hang @@ -186,6 +187,7 @@ Feature: Scrolling When I run :scroll-perc with count 50 Then the page should be scrolled vertically + @qtwebengine_skip: Causes memory leak... Scenario: :scroll-perc with a very big value When I run :scroll-perc 99999999999 Then no crash should happen @@ -248,6 +250,7 @@ Feature: Scrolling When I run :scroll-page --top-navigate prev 0 -1 Then data/hello3.txt should be loaded + @qtwebengine_skip: Causes memory leak... Scenario: :scroll-page with a very big value When I run :scroll-page 99999999999 99999999999 Then the error "Numeric argument is too large for internal int representation." should be shown