From 8c227324fecac2be94ca16be7db336e9da0a25cc Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Fri, 9 Jan 2015 22:13:23 +0100 Subject: [PATCH] Use qurl_from_user_input() in urlutils.is_url(). It seems 354018efcd41df3f26c0c4830e43185a6c64f97f broke IPv6 IPs on older Qt versions: ====================================================================== FAIL: test_urls (qutebrowser.test.utils.test_urlutils.IsUrlTests) (url='2001:41d0:2:6c11::1') Test things which are URLs. ---------------------------------------------------------------------- Traceback (most recent call last): File "/var/lib/buildbot/slaves/slave/ubuntu-utopic/build/qutebrowser/test/utils/test_urlutils.py", line 168, in test_urls self.assertTrue(urlutils.is_url(url), url) AssertionError: False is not true : 2001:41d0:2:6c11::1 --- qutebrowser/utils/urlutils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/utils/urlutils.py b/qutebrowser/utils/urlutils.py index 8bfe1d582..d6a932bfa 100644 --- a/qutebrowser/utils/urlutils.py +++ b/qutebrowser/utils/urlutils.py @@ -224,7 +224,7 @@ def is_url(urlstr): url = _is_url_naive(urlstr) else: raise ValueError("Invalid autosearch value") - return url and QUrl.fromUserInput(urlstr).isValid() + return url and qurl_from_user_input(urlstr).isValid() def qurl_from_user_input(urlstr):