From 8af5cfb4ac9e6d928cfeb0522fa729ba616df70a Mon Sep 17 00:00:00 2001 From: Martin Tournoij Date: Fri, 31 Mar 2017 16:16:31 +0100 Subject: [PATCH] Add a modeline to all the *.feature files MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This really tripped me up yesterday, My "Vim default" is to use tabs. This (where `!···` is a tab) does not work as you'll hope it works: Scenario: Retrying a failed download when the directory didn't exist (issue 2445) When I download http://localhost:(port)/data/downloads/download.bin to And I wait for the error "Download error: No such file or directory: *" And I make the directory And I run :download-retry !···!···And I wait until the download is finished Then the downloaded file should exist Examples: | path | mkdir | expected | | asd/zxc/ | asd/zxc | asd/zxc/download.bin | Unfortunately, pytest-bdd uses the "Python 2 behaviour" of "expand all tabs to 8 spaces", and doesn't give any errors on strange/inconsistent whitespace. It can cause very confusing errors. --- tests/end2end/features/adblock.feature | 2 ++ tests/end2end/features/backforward.feature | 2 ++ tests/end2end/features/caret.feature | 2 ++ tests/end2end/features/completion.feature | 2 ++ tests/end2end/features/downloads.feature | 2 ++ tests/end2end/features/editor.feature | 2 ++ tests/end2end/features/hints.feature | 2 ++ tests/end2end/features/history.feature | 2 ++ tests/end2end/features/invoke.feature | 2 ++ tests/end2end/features/javascript.feature | 2 ++ tests/end2end/features/keyinput.feature | 2 ++ tests/end2end/features/marks.feature | 2 ++ tests/end2end/features/misc.feature | 2 ++ tests/end2end/features/navigate.feature | 2 ++ tests/end2end/features/open.feature | 2 ++ tests/end2end/features/prompts.feature | 2 ++ tests/end2end/features/scroll.feature | 2 ++ tests/end2end/features/search.feature | 2 ++ tests/end2end/features/sessions.feature | 2 ++ tests/end2end/features/set.feature | 2 ++ tests/end2end/features/spawn.feature | 2 ++ tests/end2end/features/tabs.feature | 2 ++ tests/end2end/features/urlmarks.feature | 2 ++ tests/end2end/features/utilcmds.feature | 2 ++ tests/end2end/features/yankpaste.feature | 2 ++ tests/end2end/features/zoom.feature | 2 ++ 26 files changed, 52 insertions(+) diff --git a/tests/end2end/features/adblock.feature b/tests/end2end/features/adblock.feature index c33df30fe..c400df25f 100644 --- a/tests/end2end/features/adblock.feature +++ b/tests/end2end/features/adblock.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Ad blocking Scenario: Simple adblock update diff --git a/tests/end2end/features/backforward.feature b/tests/end2end/features/backforward.feature index 8f970837b..413ee9d95 100644 --- a/tests/end2end/features/backforward.feature +++ b/tests/end2end/features/backforward.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Going back and forward. Testing the :back/:forward commands. diff --git a/tests/end2end/features/caret.feature b/tests/end2end/features/caret.feature index 47b00622d..79a7b9d8f 100644 --- a/tests/end2end/features/caret.feature +++ b/tests/end2end/features/caret.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Caret mode In caret mode, the user can select and yank text using the keyboard. diff --git a/tests/end2end/features/completion.feature b/tests/end2end/features/completion.feature index 87db94e8d..b6c62336c 100644 --- a/tests/end2end/features/completion.feature +++ b/tests/end2end/features/completion.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Using completion Scenario: No warnings when completing with one entry (#1600) diff --git a/tests/end2end/features/downloads.feature b/tests/end2end/features/downloads.feature index fe312944f..dec28339f 100644 --- a/tests/end2end/features/downloads.feature +++ b/tests/end2end/features/downloads.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Downloading things from a website. Background: diff --git a/tests/end2end/features/editor.feature b/tests/end2end/features/editor.feature index 947dba0b0..e94e8b63c 100644 --- a/tests/end2end/features/editor.feature +++ b/tests/end2end/features/editor.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Opening external editors ## :edit-url diff --git a/tests/end2end/features/hints.feature b/tests/end2end/features/hints.feature index 5fac84402..7dc7c42ce 100644 --- a/tests/end2end/features/hints.feature +++ b/tests/end2end/features/hints.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Using hints # https://bugreports.qt.io/browse/QTBUG-58381 diff --git a/tests/end2end/features/history.feature b/tests/end2end/features/history.feature index 2df4ada21..a28f2c89e 100644 --- a/tests/end2end/features/history.feature +++ b/tests/end2end/features/history.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Page history Make sure the global page history is saved correctly. diff --git a/tests/end2end/features/invoke.feature b/tests/end2end/features/invoke.feature index 4b50f2af7..95ff3ab5e 100644 --- a/tests/end2end/features/invoke.feature +++ b/tests/end2end/features/invoke.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Invoking a new process Simulate what happens when running qutebrowser with an existing instance diff --git a/tests/end2end/features/javascript.feature b/tests/end2end/features/javascript.feature index 13ab0d96a..ab96866be 100644 --- a/tests/end2end/features/javascript.feature +++ b/tests/end2end/features/javascript.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Javascript stuff Integration with javascript. diff --git a/tests/end2end/features/keyinput.feature b/tests/end2end/features/keyinput.feature index 6777056e8..452d66757 100644 --- a/tests/end2end/features/keyinput.feature +++ b/tests/end2end/features/keyinput.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Keyboard input Tests for :bind and :unbind, :clear-keychain and other keyboard input diff --git a/tests/end2end/features/marks.feature b/tests/end2end/features/marks.feature index e2738e23f..28de753c9 100644 --- a/tests/end2end/features/marks.feature +++ b/tests/end2end/features/marks.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Setting positional marks Background: diff --git a/tests/end2end/features/misc.feature b/tests/end2end/features/misc.feature index 5e13e1feb..9a4f33844 100644 --- a/tests/end2end/features/misc.feature +++ b/tests/end2end/features/misc.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Various utility commands. ## :set-cmd-text diff --git a/tests/end2end/features/navigate.feature b/tests/end2end/features/navigate.feature index 5153400a4..cb57a4a15 100644 --- a/tests/end2end/features/navigate.feature +++ b/tests/end2end/features/navigate.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Using :navigate Scenario: :navigate with invalid argument diff --git a/tests/end2end/features/open.feature b/tests/end2end/features/open.feature index 89d6c9aa2..efc132466 100644 --- a/tests/end2end/features/open.feature +++ b/tests/end2end/features/open.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Opening pages Scenario: :open with URL diff --git a/tests/end2end/features/prompts.feature b/tests/end2end/features/prompts.feature index 8b687abcc..73c8bf602 100644 --- a/tests/end2end/features/prompts.feature +++ b/tests/end2end/features/prompts.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Prompts Various prompts (javascript, SSL errors, authentification, etc.) diff --git a/tests/end2end/features/scroll.feature b/tests/end2end/features/scroll.feature index 05f9c22e8..44f60aa66 100644 --- a/tests/end2end/features/scroll.feature +++ b/tests/end2end/features/scroll.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Scrolling Tests the various scroll commands. diff --git a/tests/end2end/features/search.feature b/tests/end2end/features/search.feature index a2e2bd6c9..4d8b8e17f 100644 --- a/tests/end2end/features/search.feature +++ b/tests/end2end/features/search.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Searching on a page Searching text on the page (like /foo) with different options. diff --git a/tests/end2end/features/sessions.feature b/tests/end2end/features/sessions.feature index 34a545841..6508459a5 100644 --- a/tests/end2end/features/sessions.feature +++ b/tests/end2end/features/sessions.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Saving and loading sessions Background: diff --git a/tests/end2end/features/set.feature b/tests/end2end/features/set.feature index 769605c3e..b2b165542 100644 --- a/tests/end2end/features/set.feature +++ b/tests/end2end/features/set.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Setting settings. Background: diff --git a/tests/end2end/features/spawn.feature b/tests/end2end/features/spawn.feature index 445920924..8e3f88bd1 100644 --- a/tests/end2end/features/spawn.feature +++ b/tests/end2end/features/spawn.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: :spawn Scenario: Running :spawn diff --git a/tests/end2end/features/tabs.feature b/tests/end2end/features/tabs.feature index fc456f5f0..5e571d42d 100644 --- a/tests/end2end/features/tabs.feature +++ b/tests/end2end/features/tabs.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Tab management Tests for various :tab-* commands. diff --git a/tests/end2end/features/urlmarks.feature b/tests/end2end/features/urlmarks.feature index 800b6f794..45cf1454a 100644 --- a/tests/end2end/features/urlmarks.feature +++ b/tests/end2end/features/urlmarks.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: quickmarks and bookmarks ## bookmarks diff --git a/tests/end2end/features/utilcmds.feature b/tests/end2end/features/utilcmds.feature index 5804dd8cd..0ddd1eb6b 100644 --- a/tests/end2end/features/utilcmds.feature +++ b/tests/end2end/features/utilcmds.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Miscellaneous utility commands exposed to the user. Background: diff --git a/tests/end2end/features/yankpaste.feature b/tests/end2end/features/yankpaste.feature index 52c11ed22..189f74212 100644 --- a/tests/end2end/features/yankpaste.feature +++ b/tests/end2end/features/yankpaste.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Yanking and pasting. :yank, {clipboard} and {primary} can be used to copy/paste the URL or title from/to the clipboard and primary selection. diff --git a/tests/end2end/features/zoom.feature b/tests/end2end/features/zoom.feature index 3aa39df8b..015b85b17 100644 --- a/tests/end2end/features/zoom.feature +++ b/tests/end2end/features/zoom.feature @@ -1,3 +1,5 @@ +# vim: ft=cucumber fileencoding=utf-8 sts=4 sw=4 et: + Feature: Zooming in and out Background: