From 8949afc2bfc06460c4325140035c686dc24e0613 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 11 Jun 2018 13:13:58 +0200 Subject: [PATCH] Reformat and document gen_versioninfo --- scripts/dev/gen_versioninfo.py | 37 ++++++++++++++++++++++------------ 1 file changed, 24 insertions(+), 13 deletions(-) diff --git a/scripts/dev/gen_versioninfo.py b/scripts/dev/gen_versioninfo.py index 29b86a59b..e72b4c816 100644 --- a/scripts/dev/gen_versioninfo.py +++ b/scripts/dev/gen_versioninfo.py @@ -45,21 +45,32 @@ def main(): copyright_text = qutebrowser.__copyright__ trademark_text = "qutebrowser is free software under the GNU General Public License" + # https://www.science.co.il/language/Locale-codes.php#definitions + # https://msdn.microsoft.com/en-us/library/windows/desktop/dd317756.aspx + en_us = 1033 # 0x0409 + utf_16 = 1200 # 0x04B0 + ffi = vs.FixedFileInfo(filevers, prodvers) - kids = [vs.StringFileInfo( - [vs.StringTable('040904B0', - [vs.StringStruct('Comments', comment_text), - vs.StringStruct('CompanyName', "qutebrowser.org"), - vs.StringStruct('FileDescription', "qutebrowser"), - vs.StringStruct('FileVersion', str_filevers), - vs.StringStruct('InternalName', "qutebrowser"), - vs.StringStruct('LegalCopyright', copyright_text), - vs.StringStruct('LegalTrademarks', trademark_text), - vs.StringStruct('OriginalFilename', "qutebrowser.exe"), - vs.StringStruct('ProductName', "qutebrowser"), - vs.StringStruct('ProductVersion', str_prodvers)])]), - vs.VarFileInfo([vs.VarStruct('Translation', [1033, 1200])])] + kids = [ + vs.StringFileInfo([ + # 0x0409: MAKELANGID(LANG_ENGLISH, SUBLANG_ENGLISH_US) + # 0x04B0: codepage 1200 (UTF-16LE) + vs.StringTable('040904B0', [ + vs.StringStruct('Comments', comment_text), + vs.StringStruct('CompanyName', "qutebrowser.org"), + vs.StringStruct('FileDescription', "qutebrowser"), + vs.StringStruct('FileVersion', str_filevers), + vs.StringStruct('InternalName', "qutebrowser"), + vs.StringStruct('LegalCopyright', copyright_text), + vs.StringStruct('LegalTrademarks', trademark_text), + vs.StringStruct('OriginalFilename', "qutebrowser.exe"), + vs.StringStruct('ProductName', "qutebrowser"), + vs.StringStruct('ProductVersion', str_prodvers) + ]), + ]), + vs.VarFileInfo([vs.VarStruct('Translation', [en_us, utf_16])]), + ] file_version_info = vs.VSVersionInfo(ffi, kids)