From 87951ee3a8a2ea1a38f2144b038bf6c710dfaa5b Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 19 Feb 2015 22:20:39 +0100 Subject: [PATCH] Fix crash when closing tabs on Qt 5.2.1 (Trusty) This issue was introduced in 8f1d81a6441ef9df88799ca9969122fb7fcf4f3b. --- qutebrowser/browser/webpage.py | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index f9e66454a..ff571d3ae 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -368,7 +368,15 @@ class BrowserPage(QWebPage): frame: The QWebFrame which gets saved. item: The QWebHistoryItem to be saved. """ - if frame != self.mainFrame(): + try: + if frame != self.mainFrame(): + return + except RuntimeError: + # With Qt 5.2.1 (Ubuntu Trusty) we get this when closing a tab: + # RuntimeError: wrapped C/C++ object of type BrowserPage has + # been deleted + # Since the information here isn't that important for closing + # webviews anyways, we ignore this error. return data = { 'zoom': frame.zoomFactor(),