From 8730dc6f8e24731f126cd0c73d38540b03ba3bd1 Mon Sep 17 00:00:00 2001 From: Daniel Schadt Date: Thu, 4 Aug 2016 11:16:43 +0200 Subject: [PATCH] tests: use :hint instead of :hint all download :hint all download does not use the response headers to determine the filename (the prompt is shown before a request is even done), so our long filename was pretty useless. :hint works because it does a request first and uses the right filename, but we need to wait until the prompt is shown before we can do :prompt-open-download, since the request is a bit slower and would fail otherwise. --- tests/end2end/features/downloads.feature | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/end2end/features/downloads.feature b/tests/end2end/features/downloads.feature index 7ec5da2ae..5b623442d 100644 --- a/tests/end2end/features/downloads.feature +++ b/tests/end2end/features/downloads.feature @@ -201,8 +201,9 @@ Feature: Downloading things from a website. Scenario: Directly open a download with a very long filename When I set storage -> prompt-download-directory to true And I open data/downloads/issue1725.html - And I run :hint all download + And I run :hint And I run :follow-hint a + And I wait for "Asking question text='Save file to:'>, *" in the log And I directly open the download And I wait until the download is finished Then "Opening * with [*python*]" should be logged