From 86f381a3b7595f05b93eebb6dc55ce50679ed078 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 10 Jul 2016 21:00:35 +0200 Subject: [PATCH] Skip tests using fake_web_tab on PyQt < 5.6 For some weird reason they cause a segfault in QObject::disconnect since fake_web_tab was converted to a fixture... See #1638 --- tests/helpers/fixtures.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests/helpers/fixtures.py b/tests/helpers/fixtures.py index 5ee95a2b2..83a200ebd 100644 --- a/tests/helpers/fixtures.py +++ b/tests/helpers/fixtures.py @@ -40,7 +40,7 @@ from qutebrowser.browser.webkit import cookies from qutebrowser.misc import savemanager from qutebrowser.keyinput import modeman -from PyQt5.QtCore import QEvent, QSize, Qt +from PyQt5.QtCore import PYQT_VERSION, QEvent, QSize, Qt from PyQt5.QtGui import QKeyEvent from PyQt5.QtWidgets import QWidget, QHBoxLayout, QVBoxLayout from PyQt5.QtNetwork import QNetworkCookieJar @@ -127,6 +127,8 @@ def tab_registry(win_registry): @pytest.fixture def fake_web_tab(stubs, tab_registry, qapp): """Fixture providing the FakeWebTab *class*.""" + if PYQT_VERSION < 0x050600: + pytest.skip('Causes segfaults, see #1638') return stubs.FakeWebTab