rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Consider input elements without type for hinting

Browse Source
This commit is contained in:
Florian Bruhin 2016-08-01 15:49:50 +02:00
parent 81ad3bdcdc
commit 86669600ff
3 changed files with 22 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
qutebrowser/browser/webkit/webelem.py
View File

@ -51,7 +51,8 @@ SELECTORS = {
Group.focus: '*:focus',
Group.inputs: ('input[type=text], input[type=email], input[type=url], '
'input[type=tel], input[type=number], '
'input[type=password], input[type=search], textarea'),
'input[type=password], input[type=search], '
'input:not([type]), textarea'),
}

11
tests/end2end/data/hints/input.html Normal file
View File

@ -0,0 +1,11 @@
<!DOCTYPE html>
<html>
<head>
<meta charset="utf-8">
<title>Simple input</title>
</head>
<body>
<form><input></input></form>
</body>
</html>

9
tests/end2end/features/hints.feature
View File

@ -119,6 +119,15 @@ Feature: Using hints
And I run :follow-hint a
Then the error "Invalid link clicked - *" should be shown
Scenario: Hinting inputs without type
When I open data/hints/input.html
And I run :hint inputs
And I run :follow-hint a
And I wait for "Entering mode KeyMode.insert (reason: click)" in the log
And I run :leave-mode
# The actual check is already done above
Then no crash should happen
### iframes
Scenario: Using :follow-hint inside an iframe