From 83aa936276bdf4b6f6b220932677b03e8ff195f2 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 9 Oct 2017 07:12:44 +0200 Subject: [PATCH] Ignore _on_history_trigger for destroyed tabs --- qutebrowser/browser/webengine/webenginetab.py | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index a45ff69fb..a5a15e0db 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -650,6 +650,15 @@ class WebEngineTab(browsertab.AbstractTab): @pyqtSlot() def _on_history_trigger(self): + try: + self._widget.page() + except RuntimeError: + # Looks like this slot can be triggered on destroyed tabs: + # https://crashes.qutebrowser.org/view/3abffbed (Qt 5.9.1) + # wrapped C/C++ object of type WebEngineView has been deleted + log.misc.debug("Ignoring history trigger for destroyed tab") + return + url = self.url() requested_url = self.url(requested=True)