From 824825e67da44a0eab49182db6efd5423a8aa8b0 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 28 Feb 2018 08:01:11 +0100 Subject: [PATCH] Make sure we only show dictionary warnings once After 3956f81e730463adcba05d92d0043155609aa422 where this was made a function, the warning was shown twice, causing AppVeyor to fail. --- qutebrowser/browser/webengine/webenginesettings.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index 2b9ae55e2..83453beb2 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -255,14 +255,15 @@ def _set_persistent_cookie_policy(profile): profile.setPersistentCookiesPolicy(value) -def _set_dictionary_language(profile): +def _set_dictionary_language(profile, warn=True): filenames = [] for code in config.val.spellcheck.languages or []: local_filename = spell.local_filename(code) if not local_filename: - message.warning( - "Language {} is not installed - see scripts/dictcli.py " - "in qutebrowser's sources".format(code)) + if warn: + message.warning( + "Language {} is not installed - see scripts/dictcli.py " + "in qutebrowser's sources".format(code)) continue filenames.append(local_filename) @@ -293,7 +294,7 @@ def _update_settings(option): # We're not touching the private profile's cookie policy. elif option == 'spellcheck.languages' and qtutils.version_check('5.8'): _set_dictionary_language(default_profile) - _set_dictionary_language(private_profile) + _set_dictionary_language(private_profile, warn=False) def _init_profile(profile):