From 822f6bae2cceff6e5cca4ab10a3d4cfbdf52a5b8 Mon Sep 17 00:00:00 2001 From: Ryan Roden-Corrent Date: Fri, 1 Dec 2017 07:25:21 -0500 Subject: [PATCH] Fix webkitelem test. Now that it checks tab.is_deleted we need to mock that. --- tests/unit/browser/webkit/test_webkitelem.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/unit/browser/webkit/test_webkitelem.py b/tests/unit/browser/webkit/test_webkitelem.py index c64756eb5..35b9c354b 100644 --- a/tests/unit/browser/webkit/test_webkitelem.py +++ b/tests/unit/browser/webkit/test_webkitelem.py @@ -29,7 +29,7 @@ import pytest from PyQt5.QtCore import QRect, QPoint, QUrl QWebElement = pytest.importorskip('PyQt5.QtWebKit').QWebElement -from qutebrowser.browser import webelem +from qutebrowser.browser import webelem, browsertab from qutebrowser.browser.webkit import webkitelem from qutebrowser.misc import objects from qutebrowser.utils import usertypes @@ -127,7 +127,9 @@ def get_webelem(geometry=None, frame=None, *, null=False, style=None, return style_dict[name] elem.styleProperty.side_effect = _style_property - wrapped = webkitelem.WebKitElement(elem, tab=None) + tab = mock.Mock(autospec=browsertab.AbstractTab) + tab.is_deleted.return_value = False + wrapped = webkitelem.WebKitElement(elem, tab=tab) return wrapped