rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Re-enable some createWindow tests

Browse Source
This commit is contained in:
Florian Bruhin 2016-09-05 14:45:34 +02:00
parent a52c8d6576
commit 8115fa2af8
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
tests/end2end/features/javascript.feature
View File

@ -8,7 +8,7 @@ Feature: Javascript stuff
Then the javascript message "console.log works!" should be logged Then the javascript message "console.log works!" should be logged
# Causes segfaults... # Causes segfaults...
@qtwebengine_createWindow @xfail_norun @qtwebengine_createWindow
Scenario: Opening/Closing a window via JS Scenario: Opening/Closing a window via JS
When I open data/javascript/window_open.html When I open data/javascript/window_open.html
And I run :tab-only And I run :tab-only
@ -19,7 +19,7 @@ Feature: Javascript stuff
Then "Focus object changed: *" should be logged Then "Focus object changed: *" should be logged
# Causes segfaults... # Causes segfaults...
@qtwebengine_createWindow @xfail_norun @qtwebengine_createWindow
Scenario: Opening/closing a modal window via JS Scenario: Opening/closing a modal window via JS
When I open data/javascript/window_open.html When I open data/javascript/window_open.html
And I run :tab-only And I run :tab-only
@ -28,7 +28,8 @@ Feature: Javascript stuff
And I run :tab-focus 1 And I run :tab-focus 1
And I run :click-element id close-normal And I run :click-element id close-normal
Then "Focus object changed: *" should be logged Then "Focus object changed: *" should be logged
And "WebModalDialog requested, but we don't support that!" should be logged # WebModalDialog with QtWebKit, WebDialog with QtWebEngine
And "Web*Dialog requested, but we don't support that!" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/906 # https://github.com/The-Compiler/qutebrowser/issues/906