From 7e879c93125a12c5b09b071938bb2307d674dfc1 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 25 Nov 2014 23:21:49 +0100 Subject: [PATCH] Don't add javascript-bridge only once. Otherwise, qute:settings will break when reloading it. --- qutebrowser/widgets/webview.py | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/qutebrowser/widgets/webview.py b/qutebrowser/widgets/webview.py index abc52c257..3290a010b 100644 --- a/qutebrowser/widgets/webview.py +++ b/qutebrowser/widgets/webview.py @@ -304,12 +304,9 @@ class WebView(QWebView): def add_js_bridge(self): """Add the javascript bridge for qute:... pages.""" frame = self.sender() - assert frame.url().scheme() == 'qute' - bridge = objreg.get('js-bridge') - frame.addToJavaScriptWindowObject('qute', bridge) - # We need to make sure the bridge doesn't get added on non-qute:... - # pages. - frame.javaScriptWindowObjectCleared.disconnect(self.add_js_bridge) + if frame.url().scheme() == 'qute': + bridge = objreg.get('js-bridge') + frame.addToJavaScriptWindowObject('qute', bridge) def zoom_perc(self, perc, fuzzyval=True): """Zoom to a given zoom percentage.