From 7c39600508004c5cb0bbde84f973209e61fec6f9 Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Fri, 15 Sep 2017 13:36:01 +0200
Subject: [PATCH] Change default bindings for Up/Down in command mode

Those now look at the history again.
Looking at the behavior in different applications:

- vim: History
- spacemacs: Completion if open, else history
- luakit: Completion if open, else history
- dwb: Always completion (has no history?)
- vimb: Nothing if completion open, else history
- vimperator: Always history

So this is consistent with at least some of them - the much more important
factor is that <Tab> is probably intuitively easy to discover if up/down doesn't
do what's expected, but <ctrl-p>/<ctrl-n> are not.
---
 doc/help/settings.asciidoc        | 4 ++--
 qutebrowser/config/configdata.yml | 5 ++---
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/doc/help/settings.asciidoc b/doc/help/settings.asciidoc
index f64c82f6d..3bb3fd1b7 100644
--- a/doc/help/settings.asciidoc
+++ b/doc/help/settings.asciidoc
@@ -400,13 +400,13 @@ Default:
 * +pass:[&lt;Ctrl-U&gt;]+: +pass:[rl-unix-line-discard]+
 * +pass:[&lt;Ctrl-W&gt;]+: +pass:[rl-unix-word-rubout]+
 * +pass:[&lt;Ctrl-Y&gt;]+: +pass:[rl-yank]+
-* +pass:[&lt;Down&gt;]+: +pass:[completion-item-focus next]+
+* +pass:[&lt;Down&gt;]+: +pass:[command-history-next]+
 * +pass:[&lt;Escape&gt;]+: +pass:[leave-mode]+
 * +pass:[&lt;Return&gt;]+: +pass:[command-accept]+
 * +pass:[&lt;Shift-Delete&gt;]+: +pass:[completion-item-del]+
 * +pass:[&lt;Shift-Tab&gt;]+: +pass:[completion-item-focus prev]+
 * +pass:[&lt;Tab&gt;]+: +pass:[completion-item-focus next]+
-* +pass:[&lt;Up&gt;]+: +pass:[completion-item-focus prev]+
+* +pass:[&lt;Up&gt;]+: +pass:[command-history-prev]+
 - +pass:[hint]+:
 
 * +pass:[&lt;Ctrl-B&gt;]+: +pass:[hint all tab-bg]+
diff --git a/qutebrowser/config/configdata.yml b/qutebrowser/config/configdata.yml
index ac7a59fde..4e22f3b15 100644
--- a/qutebrowser/config/configdata.yml
+++ b/qutebrowser/config/configdata.yml
@@ -2026,13 +2026,12 @@ bindings.default:
     passthrough:
       <Ctrl-V>: leave-mode
     command:
-      # FIXME:conf what to do about up/down?
       <Ctrl-P>: command-history-prev
       <Ctrl-N>: command-history-next
+      <Up>: command-history-prev
+      <Down>: command-history-next
       <Shift-Tab>: completion-item-focus prev
-      <Up>: completion-item-focus prev
       <Tab>: completion-item-focus next
-      <Down>: completion-item-focus next
       <Ctrl-Tab>: completion-item-focus next-category
       <Ctrl-Shift-Tab>: completion-item-focus prev-category
       <Ctrl-D>: completion-item-del