rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix flaky editor test.

Browse Source 
Give the process time to write its PID before trying to interrupt it.
This commit is contained in:
Ryan Roden-Corrent 2018-01-24 07:40:34 -05:00
parent 2e5595b5c6
commit 7c33ff4046
1 changed files with 6 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/end2end/features/test_editor_bdd.py
View File

@ -22,6 +22,7 @@ import json
import textwrap import textwrap
import os import os
import signal import signal
import time
import pytest_bdd as bdd import pytest_bdd as bdd
bdd.scenarios('editor.feature') bdd.scenarios('editor.feature')
@ -115,6 +116,11 @@ def kill_editor_wait(tmpdir):
def save_editor_wait(tmpdir): def save_editor_wait(tmpdir):
"""Trigger the waiting editor to write without exiting.""" """Trigger the waiting editor to write without exiting."""
pidfile = tmpdir / 'editor_pid' pidfile = tmpdir / 'editor_pid'
# give the "editor" process time to write its pid
for _ in range(10):
if pidfile.check():
break
time.sleep(1)
pid = int(pidfile.read()) pid = int(pidfile.read())
# windows has no SIGUSR2, but we don't run this on windows anyways # windows has no SIGUSR2, but we don't run this on windows anyways
# for posix, there IS a member so we need to ignore useless-suppression # for posix, there IS a member so we need to ignore useless-suppression