rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix test coverage

Browse Source
This commit is contained in:
Michal Siedlaczek 2018-03-28 12:16:50 -04:00
parent f9e702bae5
commit 7c1de99876
1 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/unit/browser/webengine/test_spell.py
View File

@ -19,6 +19,7 @@
import logging import logging
from PyQt5.QtCore import QLibraryInfo
from qutebrowser.browser.webengine import spell from qutebrowser.browser.webengine import spell
from qutebrowser.utils import usertypes from qutebrowser.utils import usertypes
@ -33,6 +34,11 @@ def test_version(message_mock, caplog):
assert msg.text == expected assert msg.text == expected
def test_dictionary_dir(monkeypatch):
monkeypatch.setattr(QLibraryInfo, 'location', lambda _: 'datapath')
assert spell.dictionary_dir() == 'datapath/qtwebengine_dictionaries'
def test_local_filename_dictionary_does_not_exist(tmpdir, monkeypatch): def test_local_filename_dictionary_does_not_exist(tmpdir, monkeypatch):
monkeypatch.setattr( monkeypatch.setattr(
spell, 'dictionary_dir', lambda: '/some-non-existing-dir') spell, 'dictionary_dir', lambda: '/some-non-existing-dir')
@ -44,9 +50,24 @@ def test_local_filename_dictionary_not_installed(tmpdir, monkeypatch):
assert not spell.local_filename('en-US') assert not spell.local_filename('en-US')
def test_local_filename_dictionary_not_installed_with_malformed(tmpdir, monkeypatch, caplog):
monkeypatch.setattr(spell, 'dictionary_dir', lambda: str(tmpdir))
(tmpdir / 'en-US.bdic').ensure()
with caplog.at_level(logging.WARNING):
assert not spell.local_filename('en-US')
def test_local_filename_dictionary_installed(tmpdir, monkeypatch): def test_local_filename_dictionary_installed(tmpdir, monkeypatch):
monkeypatch.setattr(spell, 'dictionary_dir', lambda: str(tmpdir)) monkeypatch.setattr(spell, 'dictionary_dir', lambda: str(tmpdir))
for lang_file in ['en-US-11-0.bdic', 'en-US-7-1.bdic', 'pl-PL-3-0.bdic']: for lang_file in ['en-US-11-0.bdic', 'en-US-7-1.bdic', 'pl-PL-3-0.bdic']:
(tmpdir / lang_file).ensure() (tmpdir / lang_file).ensure()
assert spell.local_filename('en-US') == 'en-US-11-0' assert spell.local_filename('en-US') == 'en-US-11-0'
assert spell.local_filename('pl-PL') == 'pl-PL-3-0' assert spell.local_filename('pl-PL') == 'pl-PL-3-0'
def test_local_filename_dictionary_installed_with_malformed(tmpdir, monkeypatch, caplog):
monkeypatch.setattr(spell, 'dictionary_dir', lambda: str(tmpdir))
for lang_file in ['en-US-11-0.bdic', 'en-US-7-1.bdic', 'en-US.bdic']:
(tmpdir / lang_file).ensure()
with caplog.at_level(logging.WARNING):
assert spell.local_filename('en-US') == 'en-US-11-0'