From 7be32dd70c1d26264b7cdcf343f6bb00d888d310 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 24 Nov 2014 21:47:22 +0100 Subject: [PATCH] Don't handle hexadecimal numbers as IP addresses. Fixes #269. --- qutebrowser/utils/urlutils.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/qutebrowser/utils/urlutils.py b/qutebrowser/utils/urlutils.py index b5c07c65e..69095a4af 100644 --- a/qutebrowser/utils/urlutils.py +++ b/qutebrowser/utils/urlutils.py @@ -85,9 +85,10 @@ def _is_url_naive(urlstr): else: # Valid IPv4/IPv6 address return True - if re.search(r'^[0-9.]+$', urlstr): - # Qt treats things like "23.42" or "1337" as valid URLs which we don't - # want to. Note we already filtered *real* valid IPs above. + if re.search(r'^([0-9.]+|0x[a-fA-F0-9]+)$', urlstr): + # Qt treats things like "23.42" or "1337" or "0xDEAD" as valid URLs + # which we don't want to. Note we already filtered *real* valid IPs + # above. return False elif not url.isValid(): return False