rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use monkeypatch.setenv instead of os.putenv.

Browse Source 
This ensures the environment is modified only for the test using the
fixture rather than for the whole test run.
This commit is contained in:
Ryan Roden-Corrent 2016-07-18 21:39:35 -04:00
parent 7d36847f77
commit 7b3406a3e4
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
tests/helpers/fixtures.py
View File

@ -435,11 +435,11 @@ def data_tmpdir(monkeypatch, tmpdir):
@pytest.fixture @pytest.fixture
def redirect_xdg_data(data_tmpdir): def redirect_xdg_data(data_tmpdir, monkeypatch):
"""Set XDG_DATA_HOME to a temp location. """Set XDG_DATA_HOME to a temp location.
While data_tmpdir covers most cases by redirecting standarddir.data(), this While data_tmpdir covers most cases by redirecting standarddir.data(), this
is not enough for places Qt references the data dir internally. For these, is not enough for places Qt references the data dir internally. For these,
we need to set the environment variable to redirect data access. we need to set the environment variable to redirect data access.
""" """
os.putenv('XDG_DATA_HOME', str(data_tmpdir)) monkeypatch.setenv('XDG_DATA_HOME', str(data_tmpdir))