rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

AbstractHistory: Check count

Browse Source
This commit is contained in:
Florian Bruhin 2018-11-29 19:28:11 +01:00
parent b2796d4a85
commit 7a3d1b0212
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qutebrowser/browser/browsertab.py
View File

@ -606,11 +606,17 @@ class AbstractHistory:
def __iter__(self) -> typing.Iterable: def __iter__(self) -> typing.Iterable:
raise NotImplementedError raise NotImplementedError
def _check_count(self, count: int) -> None:
"""Check whether the count is positive."""
if count < 0:
raise WebTabError("count needs to be positive!")
def current_idx(self) -> int: def current_idx(self) -> int:
raise NotImplementedError raise NotImplementedError
def back(self, count: int = 1) -> None: def back(self, count: int = 1) -> None:
"""Go back in the tab's history.""" """Go back in the tab's history."""
self._check_count(count)
idx = self.current_idx() - count idx = self.current_idx() - count
if idx >= 0: if idx >= 0:
self._go_to_item(self._item_at(idx)) self._go_to_item(self._item_at(idx))
@ -620,6 +626,7 @@ class AbstractHistory:
def forward(self, count: int = 1) -> None: def forward(self, count: int = 1) -> None:
"""Go forward in the tab's history.""" """Go forward in the tab's history."""
self._check_count(count)
idx = self.current_idx() + count idx = self.current_idx() + count
if idx < len(self): if idx < len(self):
self._go_to_item(self._item_at(idx)) self._go_to_item(self._item_at(idx))