From 085d1e9c10bd5bf5fdd617baa1c3f7f363492ace Mon Sep 17 00:00:00 2001 From: cryzed Date: Mon, 14 Aug 2017 00:30:45 +0200 Subject: [PATCH 1/2] :save-session --only-active-window implies --with-private for private windows --- qutebrowser/misc/sessions.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qutebrowser/misc/sessions.py b/qutebrowser/misc/sessions.py index 54ba35014..4bce00ae3 100644 --- a/qutebrowser/misc/sessions.py +++ b/qutebrowser/misc/sessions.py @@ -485,7 +485,7 @@ class SessionManager(QObject): try: if only_active_window: name = self.save(name, only_window=win_id, - with_private=with_private) + with_private=True) else: name = self.save(name, with_private=with_private) except SessionError as e: From 7073c33dce5896d5158aa551743bac8221ac8ed9 Mon Sep 17 00:00:00 2001 From: Jay Kamat Date: Sun, 13 Aug 2017 17:15:04 -0700 Subject: [PATCH 2/2] Test for saving a session with --only-active-window --- tests/end2end/features/private.feature | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tests/end2end/features/private.feature b/tests/end2end/features/private.feature index 55ded35d7..bd1059e09 100644 --- a/tests/end2end/features/private.feature +++ b/tests/end2end/features/private.feature @@ -153,3 +153,26 @@ Feature: Using private browsing - history: - url: http://localhost:*/data/numbers/1.txt - url: http://localhost:*/data/numbers/2.txt + + + Scenario: Saving a private session with only-active-window + When I open data/numbers/1.txt + And I open data/numbers/2.txt in a new tab + And I open data/numbers/3.txt in a private window + And I open data/numbers/4.txt in a new tab + And I open data/numbers/5.txt in a new tab + And I run :session-save --only-active-window window_session_name + And I run :window-only + And I run :tab-only + And I run :session-load -c window_session_name + And I wait until data/numbers/5.txt is loaded + Then the session should look like: + windows: + - tabs: + - history: + - url: http://localhost:*/data/numbers/3.txt + - history: + - url: http://localhost:*/data/numbers/4.txt + - history: + - active: true + url: http://localhost:*/data/numbers/5.txt