rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Clean up :later timers correctly on exceptions.

Browse Source
This commit is contained in:
Florian Bruhin 2014-10-08 07:52:49 +02:00
parent 50f7067d6c
commit 7956f2b8e2
1 changed files with 16 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
qutebrowser/utils/utilcmds.py
View File

@ -37,22 +37,26 @@ def later(ms: int, *command, win_id):
ms: How many milliseconds to wait. ms: How many milliseconds to wait.
*command: The command to run, with optional args. *command: The command to run, with optional args.
""" """
app = objreg.get('app')
timer = usertypes.Timer(name='later', parent=app)
timer.setSingleShot(True)
if ms < 0: if ms < 0:
raise cmdexc.CommandError("I can't run something in the past!") raise cmdexc.CommandError("I can't run something in the past!")
try:
timer.setInterval(ms)
except OverflowError:
raise cmdexc.CommandError("Numeric argument is too large for internal "
"int representation.")
cmdline = ' '.join(command) cmdline = ' '.join(command)
commandrunner = runners.CommandRunner(win_id) commandrunner = runners.CommandRunner(win_id)
timer.timeout.connect( app = objreg.get('app')
functools.partial(commandrunner.run_safely, cmdline)) timer = usertypes.Timer(name='later', parent=app)
timer.timeout.connect(timer.deleteLater) try:
timer.start() timer.setSingleShot(True)
try:
timer.setInterval(ms)
except OverflowError:
raise cmdexc.CommandError("Numeric argument is too large for "
"internal int representation.")
timer.timeout.connect(
functools.partial(commandrunner.run_safely, cmdline))
timer.timeout.connect(timer.deleteLater)
timer.start()
except: # pylint: disable=bare-except
timer.deleteLater()
raise
@cmdutils.register(scope='window') @cmdutils.register(scope='window')