From 766a1ebb6ddbc7a650ec0a1973b54be7d12c357d Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 16 May 2017 11:33:52 +0200 Subject: [PATCH] Remove wrong private browsing assertion This tried to assert that we never create a DiskCache object when private browsing is turned on. However, when initializing, we still create a global DiskCache, so this will hit when qutebrowser is started with private browsing turned on via the config. We could just not create the DiskCache at all when started in private browsing mode, however we might still need it later when opening a non-private window. --- qutebrowser/browser/webkit/cache.py | 1 - 1 file changed, 1 deletion(-) diff --git a/qutebrowser/browser/webkit/cache.py b/qutebrowser/browser/webkit/cache.py index d04a5cfac..ae717c956 100644 --- a/qutebrowser/browser/webkit/cache.py +++ b/qutebrowser/browser/webkit/cache.py @@ -33,7 +33,6 @@ class DiskCache(QNetworkDiskCache): def __init__(self, cache_dir, parent=None): super().__init__(parent) - assert not config.get('general', 'private-browsing') self.setCacheDirectory(os.path.join(cache_dir, 'http')) self._set_cache_size() objreg.get('config').changed.connect(self._set_cache_size)