From 75a8938e83709073b182fb2e0d197e758c7c0def Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Sun, 26 Nov 2017 21:49:37 +0100
Subject: [PATCH] Add flake8-bugbear

---
 .flake8                                        | 3 +++
 misc/requirements/requirements-flake8.txt      | 2 ++
 misc/requirements/requirements-flake8.txt-raw  | 1 +
 scripts/dev/run_vulture.py                     | 2 +-
 tests/unit/completion/test_completionwidget.py | 2 +-
 5 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/.flake8 b/.flake8
index 74f68c27a..06883f526 100644
--- a/.flake8
+++ b/.flake8
@@ -1,5 +1,7 @@
 [flake8]
 exclude = .*,__pycache__,resources.py
+# B001: bare except
+# B305: .next() (false-positives)
 # E128: continuation line under-indented for visual indent
 # E226: missing whitespace around arithmetic operator
 # E265: Block comment should start with '#'
@@ -31,6 +33,7 @@ exclude = .*,__pycache__,resources.py
 # D413: Missing blank line after last section (not in pep257?)
 # A003: Builtin name for class attribute (needed for attrs)
 ignore =
+    B001,B305,
     E128,E226,E265,E501,E402,E266,E722,E731,
     F401,
     N802,
diff --git a/misc/requirements/requirements-flake8.txt b/misc/requirements/requirements-flake8.txt
index 26995cb59..a031778ba 100644
--- a/misc/requirements/requirements-flake8.txt
+++ b/misc/requirements/requirements-flake8.txt
@@ -1,6 +1,8 @@
 # This file is automatically generated by scripts/dev/recompile_requirements.py
 
+attrs==17.3.0
 flake8==3.5.0
+flake8-bugbear==17.4.0
 flake8-builtins==1.0
 flake8-comprehensions==1.4.1
 flake8-copyright==0.2.0
diff --git a/misc/requirements/requirements-flake8.txt-raw b/misc/requirements/requirements-flake8.txt-raw
index 30f6c28d8..1f30b83ae 100644
--- a/misc/requirements/requirements-flake8.txt-raw
+++ b/misc/requirements/requirements-flake8.txt-raw
@@ -1,4 +1,5 @@
 flake8
+flake8-bugbear
 flake8-builtins
 flake8-comprehensions
 flake8-copyright
diff --git a/scripts/dev/run_vulture.py b/scripts/dev/run_vulture.py
index b4d064c0d..9d21ad428 100755
--- a/scripts/dev/run_vulture.py
+++ b/scripts/dev/run_vulture.py
@@ -103,7 +103,7 @@ def whitelist_generator():  # noqa
     for attr in ['visit_call', 'process_module']:
         yield 'scripts.dev.pylint_checkers.modeline.' + attr
 
-    for name, member in inspect.getmembers(configtypes, inspect.isclass):
+    for name, _member in inspect.getmembers(configtypes, inspect.isclass):
         yield 'qutebrowser.config.configtypes.' + name
     yield 'qutebrowser.config.configexc.ConfigErrorDesc.traceback'
     yield 'qutebrowser.config.configfiles.ConfigAPI.load_autoconfig'
diff --git a/tests/unit/completion/test_completionwidget.py b/tests/unit/completion/test_completionwidget.py
index b03205da7..a639daf95 100644
--- a/tests/unit/completion/test_completionwidget.py
+++ b/tests/unit/completion/test_completionwidget.py
@@ -45,7 +45,7 @@ def completionview(qtbot, status_command_stub, config_stub, win_registry,
 def test_set_model(completionview):
     """Ensure set_model actually sets the model and expands all categories."""
     model = completionmodel.CompletionModel()
-    for i in range(3):
+    for _i in range(3):
         model.add_category(listcategory.ListCategory('', [('foo',)]))
     completionview.set_model(model)
     assert completionview.model() is model