rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge branch 'blyxxyz-title_change'

Browse Source
This commit is contained in:
Florian Bruhin 2016-08-08 09:43:30 +02:00
commit 743d2dc327
3 changed files with 15 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.asciidoc
View File

@ -49,6 +49,8 @@ Changed
- Replacements like `{url}` can now also be used in the middle of an argument. - Replacements like `{url}` can now also be used in the middle of an argument.
Consequently, commands taking another command (`:later`, `:repeat` and Consequently, commands taking another command (`:later`, `:repeat` and
`:bind`) now don't immediately evaluate variables. `:bind`) now don't immediately evaluate variables.
- Tab titles in the `:buffer` completion now update correctly when a page's
title is changed via javascript.
Removed Removed
~~~~~~~ ~~~~~~~

2
qutebrowser/completion/models/miscmodels.py
View File

@ -174,6 +174,7 @@ class TabCompletionModel(base.BaseCompletionModel):
for i in range(tabbed_browser.count()): for i in range(tabbed_browser.count()):
tab = tabbed_browser.widget(i) tab = tabbed_browser.widget(i)
tab.url_changed.connect(self.rebuild) tab.url_changed.connect(self.rebuild)
tab.title_changed.connect(self.rebuild)
tab.shutting_down.connect(self.delayed_rebuild) tab.shutting_down.connect(self.delayed_rebuild)
tabbed_browser.new_tab.connect(self.on_new_tab) tabbed_browser.new_tab.connect(self.on_new_tab)
objreg.get("app").new_window.connect(self.on_new_window) objreg.get("app").new_window.connect(self.on_new_window)
@ -187,6 +188,7 @@ class TabCompletionModel(base.BaseCompletionModel):
def on_new_tab(self, tab): def on_new_tab(self, tab):
"""Add hooks to new tabs.""" """Add hooks to new tabs."""
tab.url_changed.connect(self.rebuild) tab.url_changed.connect(self.rebuild)
tab.title_changed.connect(self.rebuild)
tab.shutting_down.connect(self.delayed_rebuild) tab.shutting_down.connect(self.delayed_rebuild)
self.rebuild() self.rebuild()

11
tests/manual/completion/changing_title.html Normal file
View File

@ -0,0 +1,11 @@
<head>
<title>Old title</title>
<script type="text/javascript">
setTimeout(function(){ document.title = "New title"; }, 3000);
</script>
</head>
<body>
<p>This page should change its title after 3s.</p>
<p>When opening the :buffer completion ("gt"), the title should update while it's open.</p>
</body>