rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make url(requested=True) a keyword-only arg

Browse Source
This commit is contained in:
Florian Bruhin 2018-11-29 19:23:14 +01:00
parent cd8e3094b9
commit 73e196ff65
3 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/browser/browsertab.py
View File

@ -1015,7 +1015,7 @@ class AbstractTab(QWidget):
self._progress = perc self._progress = perc
self.load_progress.emit(perc) self.load_progress.emit(perc)
def url(self, requested: bool = False) -> QUrl: def url(self, *, requested: bool = False) -> QUrl:
raise NotImplementedError raise NotImplementedError
def progress(self) -> int: def progress(self) -> int:

2
qutebrowser/browser/webengine/webenginetab.py
View File

@ -1139,7 +1139,7 @@ class WebEngineTab(browsertab.AbstractTab):
self._openurl_prepare(url, predict=predict) self._openurl_prepare(url, predict=predict)
self._widget.load(url) self._widget.load(url)
def url(self, requested=False): def url(self, *, requested=False):
page = self._widget.page() page = self._widget.page()
if requested: if requested:
return page.requestedUrl() return page.requestedUrl()

2
tests/helpers/stubs.py
View File

@ -268,7 +268,7 @@ class FakeWebTab(browsertab.AbstractTab):
wrapped = QWidget() wrapped = QWidget()
self._layout.wrap(self, wrapped) self._layout.wrap(self, wrapped)
def url(self, requested=False): def url(self, *, requested=False):
assert not requested assert not requested
return self._url return self._url