From 7308fa97c529572967c23b97d54d796360ad5c24 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 22 May 2014 17:49:18 +0200 Subject: [PATCH] Leave hinting mode when insert mode is entered --- qutebrowser/browser/hints.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index e446e7f5f..8892c8440 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -118,6 +118,7 @@ class HintManager(QObject): self._frames = [] self._connected_frames = [] modeman.instance().left.connect(self.on_mode_left) + modeman.instance().entered.connect(self.on_mode_entered) def _hint_strings(self, elems): """Calculate the hint strings for elems. @@ -501,7 +502,7 @@ class HintManager(QObject): else: raise ValueError("No suitable handler found!") if self._target != Target.rapid: - modeman.leave('hint', 'followed') + modeman.maybe_leave('hint', 'followed') def follow_hint(self): """Follow the currently selected hint.""" @@ -522,6 +523,12 @@ class HintManager(QObject): css = self._get_hint_css(elems.elem, elems.label) elems.label.setAttribute('style', css) + @pyqtSlot(str) + def on_mode_entered(self, mode): + """Stop hinting when insert mode was entered.""" + if mode == 'insert': + modeman.maybe_leave('hint', 'insert mode') + @pyqtSlot(str) def on_mode_left(self, mode): """Stop hinting when hinting mode was left."""