build_release: Don't fail if hdiutil detach fails
This commit is contained in:
parent
c424a745d8
commit
725d4a44f0
@ -149,15 +149,19 @@ def build_osx():
|
|||||||
os.rename('qutebrowser.dmg', dmg_name)
|
os.rename('qutebrowser.dmg', dmg_name)
|
||||||
|
|
||||||
utils.print_title("Running smoke test")
|
utils.print_title("Running smoke test")
|
||||||
with tempfile.TemporaryDirectory() as tmpdir:
|
|
||||||
subprocess.check_call(['hdiutil', 'attach', dmg_name,
|
try:
|
||||||
'-mountpoint', tmpdir])
|
with tempfile.TemporaryDirectory() as tmpdir:
|
||||||
try:
|
subprocess.check_call(['hdiutil', 'attach', dmg_name,
|
||||||
binary = os.path.join(tmpdir, 'qutebrowser.app', 'Contents',
|
'-mountpoint', tmpdir])
|
||||||
'MacOS', 'qutebrowser')
|
try:
|
||||||
smoke_test(binary)
|
binary = os.path.join(tmpdir, 'qutebrowser.app', 'Contents',
|
||||||
finally:
|
'MacOS', 'qutebrowser')
|
||||||
subprocess.check_call(['hdiutil', 'detach', tmpdir])
|
smoke_test(binary)
|
||||||
|
finally:
|
||||||
|
subprocess.call(['hdiutil', 'detach', tmpdir])
|
||||||
|
except PermissionError as e:
|
||||||
|
print("Failed to remove tempdir: {}".format(e))
|
||||||
|
|
||||||
return [(dmg_name, 'application/x-apple-diskimage', 'OS X .dmg')]
|
return [(dmg_name, 'application/x-apple-diskimage', 'OS X .dmg')]
|
||||||
|
|
||||||
|
Loading…
Reference in New Issue
Block a user