rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

build_release: Don't fail if hdiutil detach fails

Browse Source
This commit is contained in:
Florian Bruhin 2017-07-04 22:16:21 +02:00
parent c424a745d8
commit 725d4a44f0
1 changed files with 13 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
scripts/dev/build_release.py
View File

@ -149,6 +149,8 @@ def build_osx():
os.rename('qutebrowser.dmg', dmg_name) os.rename('qutebrowser.dmg', dmg_name)
utils.print_title("Running smoke test") utils.print_title("Running smoke test")
try:
with tempfile.TemporaryDirectory() as tmpdir: with tempfile.TemporaryDirectory() as tmpdir:
subprocess.check_call(['hdiutil', 'attach', dmg_name, subprocess.check_call(['hdiutil', 'attach', dmg_name,
'-mountpoint', tmpdir]) '-mountpoint', tmpdir])
@ -157,7 +159,9 @@ def build_osx():
'MacOS', 'qutebrowser') 'MacOS', 'qutebrowser')
smoke_test(binary) smoke_test(binary)
finally: finally:
subprocess.check_call(['hdiutil', 'detach', tmpdir]) subprocess.call(['hdiutil', 'detach', tmpdir])
except PermissionError as e:
print("Failed to remove tempdir: {}".format(e))
return [(dmg_name, 'application/x-apple-diskimage', 'OS X .dmg')] return [(dmg_name, 'application/x-apple-diskimage', 'OS X .dmg')]