From 7162f15348219d3736a8d17785d9b6e2dff49f8f Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 23 May 2018 09:44:44 +0200 Subject: [PATCH] Use functools instead of a lambda for QTimer It reads nicer, and this is also speculative fix for #3896 as PyQt5 is hopefully better at disconnecting partial-objects from dead objects than it is with lambdas. --- qutebrowser/browser/webengine/webenginetab.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/webengine/webenginetab.py b/qutebrowser/browser/webengine/webenginetab.py index 3fcc58738..8722a3182 100644 --- a/qutebrowser/browser/webengine/webenginetab.py +++ b/qutebrowser/browser/webengine/webenginetab.py @@ -1035,8 +1035,9 @@ class WebEngineTab(browsertab.AbstractTab): log.config.debug( "Loading {} again because of config change".format( self._reload_url.toDisplayString())) - QTimer.singleShot(100, lambda url=self._reload_url: - self.openurl(url, predict=False)) + QTimer.singleShot(100, functools.partial(self.openurl, + self._reload_url, + predict=False)) self._reload_url = None if not qtutils.version_check('5.10', compiled=False):