From 71533b3456e52fffc0755e0ec6c202bde80ab3c3 Mon Sep 17 00:00:00 2001 From: Daniel Date: Sat, 24 Oct 2015 12:12:07 +0200 Subject: [PATCH] mhtml: Add comments describing the hostblock check --- qutebrowser/browser/mhtml.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/qutebrowser/browser/mhtml.py b/qutebrowser/browser/mhtml.py index d6c5de8a1..bc6f0aa6b 100644 --- a/qutebrowser/browser/mhtml.py +++ b/qutebrowser/browser/mhtml.py @@ -297,6 +297,10 @@ class _Downloader(): log.downloads.debug("loading asset at %s", url) + # Using the download manager to download host-blocked urls might crash + # qute, see the comments/discussion on + # https://github.com/The-Compiler/qutebrowser/pull/962#discussion_r40256987 + # and https://github.com/The-Compiler/qutebrowser/issues/1053 host_blocker = objreg.get('host-blocker') if host_blocker.is_blocked(url): log.downloads.debug("Skipping %s, host-blocked", url)