rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Handle title correctly for pages without title.

Browse Source 
Fixes #667.
This commit is contained in:
Florian Bruhin 2015-05-11 19:11:49 +02:00
parent 21dcf73e38
commit 6f620a6a9e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/browser/webview.py
View File

@ -378,6 +378,8 @@ class WebView(QWebView):
if url.isValid(): if url.isValid():
self.cur_url = url self.cur_url = url
self.url_text_changed.emit(url.toDisplayString()) self.url_text_changed.emit(url.toDisplayString())
if not self.title():
self.titleChanged.emit(self.url().toDisplayString())
@pyqtSlot('QMouseEvent') @pyqtSlot('QMouseEvent')
def on_mouse_event(self, evt): def on_mouse_event(self, evt):
@ -396,7 +398,7 @@ class WebView(QWebView):
@pyqtSlot() @pyqtSlot()
def on_load_finished(self): def on_load_finished(self):
"""Handle auto-insert-mode after loading finished. """Handle a finished page load.
We don't take loadFinished's ok argument here as it always seems to be We don't take loadFinished's ok argument here as it always seems to be
true when the QWebPage has an ErrorPageExtension implemented. true when the QWebPage has an ErrorPageExtension implemented.
@ -409,6 +411,12 @@ class WebView(QWebView):
self._set_load_status(LoadStatus.warn) self._set_load_status(LoadStatus.warn)
else: else:
self._set_load_status(LoadStatus.error) self._set_load_status(LoadStatus.error)
if not self.title():
self.titleChanged.emit(self.url().toDisplayString())
self._handle_auto_insert_mode(ok)
def _handle_auto_insert_mode(self, ok):
"""Handle auto-insert-mode after loading finished."""
if not config.get('input', 'auto-insert-mode'): if not config.get('input', 'auto-insert-mode'):
return return
mode_manager = objreg.get('mode-manager', scope='window', mode_manager = objreg.get('mode-manager', scope='window',