Revert "Make inspector detachable."
This reverts commit ee241c3f6c
.
Conflicts:
qutebrowser/config/configdata.py
This commit is contained in:
parent
f380eaf4cd
commit
6bc0f7e5e7
3
TODO
3
TODO
@ -63,6 +63,8 @@ Improvements / minor features
|
||||
- Display metavars for commands in input bar.
|
||||
- count support for special keys
|
||||
- set-as-default argument/command
|
||||
- Make inspector height resizable
|
||||
- Make inspector detachable (own window)
|
||||
- Enable disk caching
|
||||
QNetworkManager.setCache() and use a QNetworkDiskCache probably
|
||||
- clear cookies command
|
||||
@ -77,6 +79,7 @@ Improvements / minor features
|
||||
elem = frame.findFirstElement('*:focus')
|
||||
- somehow unfocus elements (hide blinking cursor) when insert mode is left?
|
||||
- tabs: some more padding?
|
||||
- Make it possible to open inspector in a new window.
|
||||
- Copy link location on crash mail should not copy mailto:
|
||||
- Drag&Drop of tabs to other windows
|
||||
- Use QNetworkAccessManager per QWebPage again so we can set proxy per tab.
|
||||
|
@ -215,10 +215,6 @@ DATA = OrderedDict([
|
||||
SettingValue(types.Int(), '2000'),
|
||||
"Time (in ms) to show messages in the statusbar for."),
|
||||
|
||||
('detach-inspector',
|
||||
SettingValue(types.Bool(), 'false'),
|
||||
"Whether to show the webinspector as own window."),
|
||||
|
||||
('confirm-quit',
|
||||
SettingValue(types.ConfirmQuit(), 'never'),
|
||||
"Whether to confirm quitting the application."),
|
||||
|
@ -78,10 +78,8 @@ class MainWindow(QWidget):
|
||||
self.completion = CompletionView(self)
|
||||
self.inspector = QWebInspector()
|
||||
self.inspector.hide()
|
||||
|
||||
if not config.get('ui', 'detach-inspector'):
|
||||
self._splitter.addWidget(self.inspector)
|
||||
self._splitter.setStretchFactor(0, 50)
|
||||
self._splitter.addWidget(self.inspector)
|
||||
self._splitter.setStretchFactor(0, 50)
|
||||
|
||||
self._vbox.addWidget(self._splitter)
|
||||
|
||||
@ -101,16 +99,6 @@ class MainWindow(QWidget):
|
||||
"""Resize completion if config changed."""
|
||||
if section == 'completion' and option == 'height':
|
||||
self.resize_completion()
|
||||
if section == 'ui' and option == 'detach-inspector':
|
||||
detach = config.get('ui', 'detach-inspector')
|
||||
if detach and self.inspector.parent() is not None:
|
||||
shown = self.inspector.isVisible()
|
||||
self.inspector.setParent(None)
|
||||
if shown:
|
||||
self.inspector.show()
|
||||
elif not detach and self.inspector.parent() is None:
|
||||
self._splitter.addWidget(self.inspector)
|
||||
self._splitter.setStretchFactor(0, 50)
|
||||
|
||||
def resize_completion(self):
|
||||
"""Adjust completion according to config."""
|
||||
|
Loading…
Reference in New Issue
Block a user